Issue #2: Return sorted list of interfaces in case of interfaces prop…

…erty call
sanketsudake · Feb 9, 2017 · d0ced1f · d0ced1f
1 parent 40cd9b5
commit d0ced1f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ifparser/ifconfig.py b/ifparser/ifconfig.py
@@ -130,7 +130,7 @@ def process_ignore(self, group, groupdict, matched_str):
 
     @property
     def interfaces(self):
-        return self._interfaces.keys()
+        return sorted(self._interfaces.keys())
 
     def get_interface(self, interface):
         return self._interfaces[interface]

diff --git a/tests/test_ifcfg_parser.py b/tests/test_ifcfg_parser.py
@@ -68,7 +68,7 @@ def setUp(self):
     def test_interfaces(self):
         _ifparser = self.ifparser
         self.assertEqual(len(_ifparser.interfaces), 3)
-        self.assertEqual(_ifparser.interfaces, ['lo', 'docker0', 'eth0'])
+        self.assertEqual(_ifparser.interfaces, ['docker0', 'eth0', 'lo'])
 
     def test_get(self):
         _ifparser = self.ifparser
@@ -94,4 +94,4 @@ def setUp(self):
     def test_interfaces(self):
         _ifparser = self.ifparser
         self.assertEqual(len(_ifparser.interfaces), 3)
-        self.assertEqual(_ifparser.interfaces, ['lo', 'wlan0', 'eth0'])
+        self.assertEqual(_ifparser.interfaces, ['eth0', 'lo', 'wlan0'])