-
Notifications
You must be signed in to change notification settings - Fork 93
navbar component #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navbar component #320
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,8 +26,8 @@ | |
| "gsap": "^3.13.0", | ||
| "jwt-decode": "^4.0.0", | ||
| "lucide-react": "^0.545.0", | ||
| "react": "^19.1.1", | ||
| "react-dom": "^19.1.1", | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1", | ||
|
Comment on lines
+35
to
+36
|
||
| "react-dropzone": "^14.3.8", | ||
| "react-helmet-async": "^2.0.5", | ||
| "react-hot-toast": "^2.6.0", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR downgrades React from version 19.1.1 to 18.3.1, which is a major version change, but this isn't mentioned in the PR description. The README.md indicates the project uses React 19 and even has special instructions for handling React 19 peer dependencies. This significant change should be documented and explained. Was this downgrade intentional? If so, please update the README.md to reflect this change and explain the rationale. If not, this may be an unintended change that should be reverted.