Allow to specific flavor and custom root disk in e2e test #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuckal777
previously approved these changes
Jul 14, 2025
jknipper
previously approved these changes
Jul 14, 2025
Signed-off-by: Fabian Ruff <[email protected]>
|
I think the ssh key change requires adjustments in the pipeline. |
Really? Leaving it empty means no ssh key will be provisioned which is the same as we have currently we we have no idea were the private key is for the static key we have in the tests. :) |
Signed-off-by: Fabian Ruff <[email protected]>
Nuckal777
approved these changes
Jul 29, 2025
defo89
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to run the kubernikus e2e test on KVM, for this we need a different flavor and custom root disks