Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New XSJS Service to create iCal file for selected Event #32

Merged
merged 2 commits into from
Feb 8, 2017
Merged

New XSJS Service to create iCal file for selected Event #32

merged 2 commits into from
Feb 8, 2017

Conversation

seVladimirs
Copy link
Contributor

@seVladimirs seVladimirs commented Feb 1, 2017

Linked to sapmentors/SITregParticipant#20

By calling this service you will get iCal file downloaded on your laptop. Important to pass event id.
Example GET Request: odataparticipant/ExportCalendar.xsjs?ID=1

This file is following iCalendar RFC 5545 format - https://icalendar.org/RFC-Specifications/iCalendar-RFC-5545/

Missing:

  • Organiser ID (email), this would allow informing organiser in case you cancel participation via Calendar/Outlook

@gregorwolf
Copy link
Contributor

Hi Vladimirs,

thank for this great contribution.

Would be great if you can add a test in https://github.com/sapmentors/SITreg/tree/master/test. Please create a new test 040_Participant.xsjslib following the example of 040_CoOrganizerTest.xsjslib. You can call /sap/hana/testtools/unit/jasminexs/TestRunner.xsjs?format=json&package=com.sap.sapmentors.sitreg.test to execute all the tests. When there are green on your local system please add this to this pull request and I will be happy to merge. By merging an automatic build on https://ci.computerservice-wolf.com/ will be triggered.

CU
Gregor

@gregorwolf
Copy link
Contributor

gregorwolf commented Feb 1, 2017

Please note that I had to patch /sap/hana/testtools/unit/jasminexs/lib/http.xsjslib with the following:

	var response =  client.getResponse();
	// close the connection
	client.close();	
	return response;

to avoid running out of connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants