This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
WIP: Add server_init_hook #1532
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add server_init_hook to SardanaDevice for allowing the subscribe_event in the init of the MacroServer. This modification will start to work with Tango versions 9.4.x or greater.
Based on the response of Michal to https://gitlab.com/tango-controls/pytango/-/merge_requests/419. We are going to explore the migration of run_tango_server to Pytango High-Level API using the method post_init_callback which is invoked after Util::server_init is called (and DServer exported) but before server enters event loop