-
Notifications
You must be signed in to change notification settings - Fork 52
Commits on Jun 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f2c6dd0 - Browse repository at this point
Copy the full SHA f2c6dd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0848e13 - Browse repository at this point
Copy the full SHA 0848e13View commit details
Commits on Jun 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d498b1f - Browse repository at this point
Copy the full SHA d498b1fView commit details -
improve dependent elements error message
When delete a element that depens of a motor group a better message for the user is printed.
Configuration menu - View commit details
-
Copy full SHA for 3e9fce8 - Browse repository at this point
Copy the full SHA 3e9fce8View commit details -
improve get_dependent_elements
now it takes into account if the listeners are from an object instance
Configuration menu - View commit details
-
Copy full SHA for 510f4a3 - Browse repository at this point
Copy the full SHA 510f4a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b28a6fd - Browse repository at this point
Copy the full SHA b28a6fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35cb86a - Browse repository at this point
Copy the full SHA 35cb86aView commit details
Commits on Jun 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bdf0b53 - Browse repository at this point
Copy the full SHA bdf0b53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b9359d - Browse repository at this point
Copy the full SHA 2b9359dView commit details
Commits on Jun 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 644f9e2 - Browse repository at this point
Copy the full SHA 644f9e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9929c10 - Browse repository at this point
Copy the full SHA 9929c10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 011e1a4 - Browse repository at this point
Copy the full SHA 011e1a4View commit details -
fix: pseudo elements weakref usage
- Dereference weakrefs stored in PoolBaseChannel._pseudo_elements. - Fix PoolBaseChannel.remove_pseudo_element() - Fix docstring of PoolBaseChannel.get_pseudo_elements()
Configuration menu - View commit details
-
Copy full SHA for 4569517 - Browse repository at this point
Copy the full SHA 4569517View commit details -
refactor: do not delete references to element and ctrl in PseudoCounter
Performing more tests revealed that these references are not problematic in order to remove the pseudocounter core object correctly. Finally do not delete them.
Configuration menu - View commit details
-
Copy full SHA for f22a614 - Browse repository at this point
Copy the full SHA f22a614View commit details -
fix: delete reference to core object in MotorGroup
Seems like PyTango/Tango keeps alive Device objects after deleting them (to be verified). These objects keep reference to the Sardana core objects, making it impossible to delete them and affecting the dependency relations. Delete reference to the motor_group in order to avoid this problem.
Configuration menu - View commit details
-
Copy full SHA for 7701e4c - Browse repository at this point
Copy the full SHA 7701e4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ba422c - Browse repository at this point
Copy the full SHA 0ba422cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08cfe48 - Browse repository at this point
Copy the full SHA 08cfe48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8efa6ac - Browse repository at this point
Copy the full SHA 8efa6acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45f38e3 - Browse repository at this point
Copy the full SHA 45f38e3View commit details
Commits on Jun 29, 2021
-
fix: do not pas meas grp as "head" kwarg to acquisition.prepare()
"head" kwarg is not used by the acquisition actions and it ends up as strong reference in the acquisition sub-actions. This leads to a cycle reference of the measurement group and the acquisition actions causing problems when discovering dependent elements when deleting an element.
Configuration menu - View commit details
-
Copy full SHA for c9599df - Browse repository at this point
Copy the full SHA c9599dfView commit details -
fix: set PoolController.operator as weakref
Measurement group becomes an operator of the controller during an acquisition and remains as operator after. This creates an additional strong reference to the measurement group making it impossible to really delete causing troubles when discovering dependent elements on an element deletion. Use weakref.ref instead.
Configuration menu - View commit details
-
Copy full SHA for e9a8900 - Browse repository at this point
Copy the full SHA e9a8900View commit details -
test: fix order of deleting elements in tearDown()
When deleting element, no dependent element can exist. First delete pseudo element and pseudo controller, and then the physical ones.
Configuration menu - View commit details
-
Copy full SHA for ff95a1e - Browse repository at this point
Copy the full SHA ff95a1eView commit details -
test: delete motor groups created in some tests
When deleting an element no dependent elements can exist. Delete the motor groups before the physical motors are deleted.
Configuration menu - View commit details
-
Copy full SHA for cf2851d - Browse repository at this point
Copy the full SHA cf2851dView commit details -
fix: gc.collect() pseudo counters with cycle references
Pseudo counters must have cycle references with physical elements. This causes problems when deleting elements after prior deletion of pseudo counters. This was discovered with the following tests: - sardana/macroserver/macros/test/test_scanct.py::AscanctTest::test_ascanct_macro_runs_4 - sardana/macroserver/macros/test/test_scanct.py::AscanctTest::test_ascanct_macro_stops - sardana/macroserver/macros/test/test_scanct.py::A2scanctTest::test_a2scanct_macro_runs - sardana/macroserver/macros/test/test_scanct.py::MeshctTest::test_meshct_macro_runs - sardana/tango/pool/test/test_measurementgroup.py::TangoAcquisitionTestCase::test_meas_cont_acquisition_2 - sardana/tango/pool/test/test_measurementgroup.py::TangoAcquisitionTestCase::test_stop_meas_cont_acquisition_3 - sardana/taurus/core/tango/sardana/test/test_measgrpstress.py::TestStressMeasurementGroup::test_stress_count_2 - sardana/taurus/core/tango/sardana/test/test_measgrpstress.py::TestStressMeasurementGroup::test_stress_count_3 - sardana/taurus/core/tango/sardana/test/test_measgrpstress.py::TestStressMeasurementGroup::test_stress_count_4 - sardana/taurus/core/tango/sardana/test/test_measgrpstress.py::TestStressMeasurementGroup::test_stress_count_6 Force gc.collect() to avoid this problem.
Configuration menu - View commit details
-
Copy full SHA for 97a96ee - Browse repository at this point
Copy the full SHA 97a96eeView commit details
Commits on Jul 20, 2021
-
refactor: change return type of get_dependent_elements()
get_dependent_elements() returns only element name. Change the return value to return the dependent elements objects in order to extend use cases of this method e.g. allow to check the type of the returned dependent elements.
Configuration menu - View commit details
-
Copy full SHA for 146edfa - Browse repository at this point
Copy the full SHA 146edfaView commit details -
call gc.collect() only in case of PseudoCounters
gc.collect() workaround is tried if any kind of dependent element resides in the pool. Call it only in the case of pseudo counters.
Configuration menu - View commit details
-
Copy full SHA for b055e77 - Browse repository at this point
Copy the full SHA b055e77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04f0ecf - Browse repository at this point
Copy the full SHA 04f0ecfView commit details
Commits on Jul 21, 2021
-
fix: meas group with undefined disabled channel
Disabled channels in the measurement group are considered as not members of the group. They neither appear in "element list" attribute nor the measurement group listens to their events. Hence it is possible to undefine an experimental channel which is disabled. This may lead to a situation when we try to enable again an undefined channel. Consider this case by not accepting a configuration which contains an undefined element. Also allow to acquire with a measurement group which contains and undefined and disabled channel.
Configuration menu - View commit details
-
Copy full SHA for 6ac7aa6 - Browse repository at this point
Copy the full SHA 6ac7aa6View commit details
Commits on Jul 22, 2021
-
add has_dependent_elements() to PoolBaseElement
PoolElement implements get_dependent_elements() and has_dependent_elements() while PoolBaseElement only implements get_dependent_elements(). Implement has_dependent_elements() also for the PoolBaseElement to be able to use both methods on any type of Sardana element.
Configuration menu - View commit details
-
Copy full SHA for 7f84584 - Browse repository at this point
Copy the full SHA 7f84584View commit details -
fix: gc.collect() of dependent elements
cycle-reference may exist between an element and a traceback stored in SardanaValue or SardanaAttribute as a consequence of getting sys.exc_info(). Keeping a list of dependent elements in the scope of delete_element() makes it impossible to gc.collect() to collect the cycled objects. Use has_dependent_elements() in order to determine if there are dependent elements and then call the gc.collect(). Also, do not call it conditionally only for the pseudo counters but for any element type - the cycle may be created for between any alement and a traceback.
Configuration menu - View commit details
-
Copy full SHA for 563e299 - Browse repository at this point
Copy the full SHA 563e299View commit details