-
Notifications
You must be signed in to change notification settings - Fork 52
Add ascanct parameter output #1652
Add ascanct parameter output #1652
Conversation
Outputs a table of motor information before running a continuous scan, e.g. velocity, acceleration etc.
Thanks for the implementation. I thinks it is nice like this. The only comment that I could do: perhaps |
Thanks for you comment. It is somehow not very clear that what the number of the table means. So should we add a explanation sentence before the information table? Maybe that will make the output look heavy? |
We have updated the output a bit:
Also note that this table will be output for each waypoint, e.g. when doing a mesh scan, interleaved with the scan output. This is necessary since the motor settings will be changed. |
I think this PR makes the following tests fail:
I think the tests need to be adapted to the new output lines. |
I will work on the tests to fix the CI. |
ascanct and meshct tests are performing validation of macro outputs. #1652 introduced a table with motor parameters showed with macro output and this breaks the tests. Adapt tests to ignore the table with motor parameters.
Those tests are already fixed with 99a18fd. |
Adds a table with some helpful output of the motor settings that are about to be used in a continuous scan.
In order to implement this, we had to change how the header of the scan table is output; it is now printed when the first point arrives, and not immediately. This also prevents some issues with info/debug messages appearing after the header.
The original issue #692 also suggests showing the restored settings after the scan but for similar reasons (see issue #1651) it is currently commented out. It can be added in whenever that issue is solved.
Example:
Opinions on how the output should be formatted are very welcome.
Fixes #692