This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Refactor pool external object #1660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ways of retrieving the tango database host between PyTango and TangoNameValidators are inconsistent. For instance, inside a docker container PyTango returns <docker_network>.<docker_container_name>:<port> while using a Taurus validator returns the host and port specified by the TANGO_HOST environment variable. Use Taurus validators instead of accessing PyTango database host and port API for discovery the full name of a PoolTangoObject.
PoolExternalObject requires many kwargs describing the object identity, this forces the API users to discover those kwargs using Taurus validators. Since PoolTangoObject can do this discovery by itself, we decided to change the PoolExternalObject API and we adapted its usage in Sardana code base.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #1053 we found that full name of the Pool Tango object (External measurement group channel. i.e: /sys/tg_test/1/ampli) full name is wrongly discovered.
The ways of retrieving the tango database host between PyTango and TangoNameValidators are inconsistent. For instance, inside a docker container PyTango returns <docker_network>.<docker_container_name>: while using a Taurus validator returns the host and port specified by the TANGO_HOST environment variable. Leading to names like: "tango://sardana_network. sardana_dev_databaseds:10000/sys/tg_test/1/ampli" instead of "tango://databaseds:10000/sys/tg_test/1/ampli".
The use of Taurus validators instead of accessing PyTango database host and port API for discovery the full name of a PoolTangoObject fixes the problem.
PoolExternalObject requires many kwargs describing the object identity, this forces the API users to discover those kwargs using Taurus validators. Since PoolTangoObject can do this discovery by itself, we decided to change the PoolExternalObject API and we adapted its usage in Sardana code base.