Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy failures #94

Closed
wants to merge 1 commit into from
Closed

Fix mypy failures #94

wants to merge 1 commit into from

Conversation

notatallshaw
Copy link
Collaborator

Related to python/mypy#1153

This became an issue with mypy running on Python 3.10 (I guess collections.Mapping and collections.Sequence were finally removed).

It's causing mypy to fail in latest PRs: #93

@uranusjr
Copy link
Member

Adding a compat.pyi file is probably more consistent to how typing is handled in the repo.

@notatallshaw notatallshaw mentioned this pull request Oct 31, 2021
Merged
@notatallshaw
Copy link
Collaborator Author

Adding a compat.pyi file is probably more consistent to how typing is handled in the repo.

Oh yes, I missed because I forget about pyi files. Created a new PR: #95

@notatallshaw notatallshaw deleted the fix_mypy_310 branch October 31, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notatallshaw @uranusjr