Github Actions maven.yml: Add java 17 to matrix #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the Github Actions build, I'm not sure why this was excluded -- maybe there was a good reason?
Prepare for building with JDK 17.
|
Interesting, the behavior of the tests under Github Actions tests on macOS is as I predicted above (passes on JDK 11, fails on JDK 17 with a PowerMock/modules issue) but the Linux tests are failing with a "no headless X11" issue on both JDK 11 and JDK 17. I converted this PR to DRAFT since until the above issues are resolved it does not build. |
|
Hi @msgilligan, Can you please confirm that this webcam-capture library will open end user's desktop/laptop camera when user is accessing my web application via browser? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Java 17 to the matrix in
maven.yml.There is currently an issue with Powermock and Java 17 that prevent the
driver-vlcjmodule from successfully running tests, so this PR currently breaks the build. (I'm not sure how to fix the PowerMock issue, I'm hoping someone with more knowledge of PowerMock and/or the tests indriver-vlcjthat use it will provide a solution.)This PR depends upon PR #893 (so that the GitHub Actions build proceeds far enough to illustrate the remaining issue in
driver-vlcj)