Skip to content

feat: (IAC-1117) WIP: air gap installation and additionnal fixes #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

momiji
Copy link

@momiji momiji commented Jan 18, 2023

As explained in #372, this is a WIP PR for all changes required to have a better air gapped installation.

Changes:

  • add V4_CFG_CERTS for certs.zip file location
  • prevent viya4-orders-cli when all 3 required order files are configured (certs, license, deployment assets)
  • add V4_CFG_URL for repository warehouse url, defaults to https://ses.sas.download/ses
  • updated docs for new variables
  • new doc AirGapInstallation.md for what we've discovered so far - sorry for my bad/mean english wordings

We're still working on first installation, new items may be added later.

@thpang thpang changed the base branch from main to staging February 7, 2023 13:51
@thpang thpang marked this pull request as draft February 7, 2023 13:51
@momiji momiji marked this pull request as ready for review May 3, 2023 07:16
@sayeun sayeun changed the title WIP: air gap installation and additionnal fixes feat: (IAC-1117) WIP: air gap installation and additionnal fixes Jul 19, 2023
@momiji
Copy link
Author

momiji commented Aug 28, 2023

While working on updating to 2023.08 we had time to check if it was possible to inject the repositoryWarehouse.url after the sasdeployment.yaml generation.

It is indeed possible, hence this is not absolutely required, as it is possible to do so using tools like xjq or yq (jq for yaml files).

$ cat sasdeployment.yaml | xjq -y \
    '(select(.kind=="SASDeployment").spec.repositoryWarehouse.url=$REPOSITORY)' \
    --arg REPOSITORY "$REPOSITORY"

However I still believe it is better to be able to do it automatically, of course :)

Copy link

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale Open for 30 days with no activity label Mar 30, 2025
@PhanikumarThodupunoori
Copy link
Contributor

Thanks for the contribution @momiji . I'm opening a PM feature request for the air gap installation.

@PhanikumarThodupunoori PhanikumarThodupunoori added the PM Feature Request Requires Project Management approval label Mar 31, 2025
@github-actions github-actions bot removed the stale Open for 30 days with no activity label Apr 2, 2025
@PhanikumarThodupunoori
Copy link
Contributor

After careful review and in alignment with the direction provided by the Platform Services leadership team, it has been confirmed that dark-site additions will not be implemented in DaC. As a result, I will be closing the associated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PM Feature Request Requires Project Management approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants