-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (PSKD-709) Add Support for NetApp Volumes #224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ritika Patil <[email protected]>
Signed-off-by: Ritika Patil <[email protected]>
Signed-off-by: Ritika Patil <[email protected]>
riragh
force-pushed
the
support_netapp
branch
from
November 14, 2024 20:01
30a10d4
to
654744e
Compare
Signed-off-by: Ritika Patil <[email protected]>
ndickens
approved these changes
Nov 20, 2024
saschjmil
approved these changes
Nov 20, 2024
dhoucgitter
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR makes the required changes to add support for Google NetApp volumes.
Resources were added using the NetApp Volume on Google Terraform provider
New variable
storage_type_backend
has been introduced to choose the backend type. To use Google NetApp volume user is expected to setstorage_type_backend = netapp
.If
storage_type=standard
the default is "nfs"; Ifstorage_type=ha
the default is "filestore".Valid Values: "nfs" if
storage_type=standard
; "filestore" or "netapp" ifstorage_type=ha
.Tests:
Verified following scenarios:
storage_type = "ha"
storage_type = "ha"
,storage_type_backend = "netapp"
,netapp_protocols = ["NFSV3"]
storage_type = "ha"
,storage_type_backend = "netapp"
,netapp_protocols = ["NFSV4"]