Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (PSKD-709) Add Support for NetApp Volumes #224

Merged
merged 13 commits into from
Nov 21, 2024
Merged

Conversation

riragh
Copy link
Member

@riragh riragh commented Nov 6, 2024

Changes:

This PR makes the required changes to add support for Google NetApp volumes.
Resources were added using the NetApp Volume on Google Terraform provider

New variable storage_type_backend has been introduced to choose the backend type. To use Google NetApp volume user is expected to set storage_type_backend = netapp.

If storage_type=standard the default is "nfs"; If storage_type=ha the default is "filestore".
Valid Values: "nfs" if storage_type=standard; "filestore" or "netapp" if storage_type=ha.

Tests:

Verified following scenarios:

Scenario Description Order Cadence Verification
1 Defaults Fast 2020 storage_type is "standard", storage_type_backend is "nfs". Viya deployment is successful.
2 storage_type = "ha" Fast 2020 storage_type is "ha", storage_type_backend is "filestore". Viya deployment is successful.
3 storage_type = "ha", storage_type_backend = "netapp", netapp_protocols = ["NFSV3"] Fast 2020 storage_type is "ha", storage_type_backend is "netapp". NFS protocol is set to NFSv3. Viya deployment is successful.
4 storage_type = "ha", storage_type_backend = "netapp", netapp_protocols = ["NFSV4"] Fast 2020 storage_type is "ha", storage_type_backend is "netapp". NFS protocol is set to NFSv4.1. Viya deployment runs into mount setup issue for CAS and launcher. See internal ticket for details.

@riragh riragh added the enhancement New feature or request label Nov 6, 2024
@riragh riragh self-assigned this Nov 6, 2024
@riragh riragh marked this pull request as draft November 6, 2024 20:45
@riragh riragh marked this pull request as ready for review November 19, 2024 20:17
@riragh riragh merged commit be09950 into staging Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants