Skip to content

feat: (IAC-1187) Update METRICS_SERVER_CHART_VERSION default to 3.11.0#99

Merged
jarpat merged 1 commit intostagingfrom
IAC-1187
Jan 10, 2024
Merged

feat: (IAC-1187) Update METRICS_SERVER_CHART_VERSION default to 3.11.0#99
jarpat merged 1 commit intostagingfrom
IAC-1187

Conversation

@jarpat
Copy link
Copy Markdown
Contributor

@jarpat jarpat commented Jan 8, 2024

Changes

Update the default METRICS_SERVER_CHART_VERSION default to 3.11.0 to pull in fixes and improvements. This version is compatible with K8s 1.19+
https://github.com/kubernetes-sigs/metrics-server?tab=readme-ov-file#compatibility-matrix

Tests

Scenario Provider kubectl version cluster_version cluster_cni cluster_cni_version cluster_cri cluster_cri_version METRICS_SERVER_CHART_VERSION Order Cadence
1 OSS 1.27.9 1.26.12 calico 3.27.0 containerd 1.6.26 3.11.0 * fast:2020
2 OSS 1.27.9 1.27.9 calico 3.27.0 containerd 1.6.26 3.11.0 * fast:2020
3 OSS 1.27.9 1.28.5 calico 3.27.0 containerd 1.6.26 3.11.0 * fast:2020

@jarpat jarpat added the enhancement New feature or request label Jan 8, 2024
@jarpat jarpat self-assigned this Jan 8, 2024
@dhoucgitter
Copy link
Copy Markdown
Member

@thpang , I think we intentionally removed the metrics-server APP_VERSION from our yaml a while ago since it had no bearing on the chart install and seemed confusing, however, wondering if our doc should say something about which app version of metrics-server is installed by default since that is not easy to tell on the surface?

Copy link
Copy Markdown
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thpang
Copy link
Copy Markdown
Member

thpang commented Jan 9, 2024

Might be a good idea to reference like you said

@jarpat
Copy link
Copy Markdown
Contributor Author

jarpat commented Jan 9, 2024

Might be a good idea to reference like you said

@dhoucgitter
We did remove that appVersion in viya4-deployment where metrics server is installed specifically for AWS, however we never had the appVersion in this repo.
However, I do agree that having an quick reference for users to figure out what appVersion the chart version translates to would be useful. In this repo the METRICS_SERVER_* variables are not documented but a user could change them if they come across it, in viya4-deployment it is exposed and present in the config-vars. I have another ticket to also make an update in that repo and will include a link for the user in the doc to determine the metrics server appVersion.

@dhoucgitter
Copy link
Copy Markdown
Member

@jarpat , that sounds like it would be a helpful addition in both projects. Thanks for adding it.

@jarpat jarpat merged commit 91808d7 into staging Jan 10, 2024
@jarpat jarpat deleted the IAC-1187 branch January 10, 2024 18:45
@jarpat jarpat mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants