Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #244

Closed
wants to merge 2 commits into from
Closed

Update README.md #244

wants to merge 2 commits into from

Conversation

Docle
Copy link

@Docle Docle commented Dec 3, 2020

Maybe, it should be 'dictionary' here?

Maybe, it should be 'dictionary' here?
@@ -734,7 +734,7 @@ What is going on here?
2
>>> dictionary in another_set
True
>>> another_set.add(another_ordered_dict)
>>> another_set.add(dictionary)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the statement above it should be dictionary. Nice catch though, thanks..

@nifadyev
Copy link
Contributor

Hey @Docle , are you planning to make requested changes and complete the PR?

@Docle
Copy link
Author

Docle commented Oct 29, 2024

Hey @Docle , are you planning to make requested changes and complete the PR?

Sorry, I'd be happy to complete the PR, but I don't have any more git experience and don't know what to do next, can you help me complete it?

@nifadyev
Copy link
Contributor

Sure, firstly, you'd better review @satwikkansal comment and make necessary changes. Then you should probably wait for #350 to be merged into main. Then you should setup a virtual environment, install dependencies, and run nox for changed snippet. Sorry, that these steps not in CONTRIBUTION guide, we are working on it at the moment.
Please don't hesitate to ask any occurred question.

@Docle
Copy link
Author

Docle commented Oct 29, 2024

Sure, firstly, you'd better review @satwikkansal comment and make necessary changes. Then you should probably wait for #350 to be merged into main. Then you should setup a virtual environment, install dependencies, and run nox for changed snippet. Sorry, that these steps not in CONTRIBUTION guide, we are working on it at the moment. Please don't hesitate to ask any occurred question.

OH, after reviewing @satwikkansal comment this time, I think I misunderstood it before, there should be no problem here. I think I should close this request now. Sorry for the trouble.

@Docle Docle closed this Oct 30, 2024
@Docle Docle deleted the patch-1 branch October 31, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants