Better ci (#127)

* Use `npm ci` and build app on PRs * deploy on main * Use same CI env var setting for PR pipeline and deployment --------- Co-authored-by: Benjamin Karran <[email protected]>
saucelabs · Jun 20, 2024 · 5b5d269 · 5b5d269
1 parent 7a84dfe
commit 5b5d269
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/.github/workflows/github-pages.yml b/.github/workflows/github-pages.yml
@@ -1,9 +1,9 @@
 name: github pages release
 
-on: workflow_dispatch
-#   push:
-#     branches:
-#       - main
+on:
+  push:
+    branches:
+      - main
 #     paths:
 #       - '.storybook'
 #       - 'public'
@@ -28,7 +28,7 @@ jobs:
           CI: false
         run: |
           ls
-          npm install
+          npm ci
           npm run build
 
       - name: Build storybook

diff --git a/.github/workflows/sample-app-web.yml b/.github/workflows/sample-app-web.yml
@@ -37,7 +37,10 @@ jobs:
 
     # Site Testing steps
     - name: Install dependencies
-      run: npm install
+      run: npm ci
+
+    - name: Build
+      run: CI=false npm run build
 
     - name: Run Unit Tests and generate coverage report
       run: npm run test.coverage

diff --git a/Dockerfile b/Dockerfile
@@ -8,4 +8,4 @@ ENV PATH="$HOME/sc-4.8.2-linux/bin:$PATH"
 # web app
 WORKDIR /sample-app-web
 COPY . .
-RUN npm install
+RUN npm ci