IRIS-826 add long inventory list #115
Conversation
|
Were you able to build and run the app locally? Last time I tried it didn't work. |
|
I was able to do that after downgrading node and python version |
| @@ -15,7 +14,8 @@ import Select from "../components/Select"; | |||
| import "./Inventory.css"; | |||
| import { BacktraceClient } from "@backtrace-labs/react"; | |||
|
|
|||
| const Inventory = () => { | |||
| const Inventory = ({data}) => { | |||
There was a problem hiding this comment.
Perhaps we should have this be data = InventoryData with the original import so we default to the current behavior? Would make it require no changes to the existing tests, too.
There was a problem hiding this comment.
I introduced a second route for an inventory with different set of data. In future will probably add lazy loading feature there and I think it will be easier to test with a prop instead of dealing with routes to define which data should be used. With next iteration I can change prop into longData: boolean and deal importing data in only one place.
|
@diemol Can you take a look? I need also your approval because you are the code owner. |
One-line summary
Description
Added a new page with longer inventory (didn't want to break other teams tests)
Types of Changes
Tasks
List of tasks you will do to complete the PR
Review
List of tasks the reviewer must do to review the PR
Deployment Notes
These should highlight any db migrations, feature toggles, etc.