chore: Align tooling with team standards (#278)

* Align pre-commit with team norms defined in devx-ts-starter repo

* Remove babel

Using tsc for compilation

* Cleanup unnecessary @typescript-eslint/* deps

Included in typescript-eslint package

* Update to eslint@9

* Align jest config with team norms in devx-ts-starter

* Actually run pre-commit hook

* Update deprecated ts-eslint rule to newer name

* Configure coverage src for jest properly

Coverage stats are currently useless, however.

* Don't init husky in ci

* Downgrade python for compat with gsutil

* Revert overzealous prettifying

* apply pretty-quick to the same set of files we do for fmt

* Revert overzelous prettifying

.github/workflows/release.yml

@@ -59,6 +59,8 @@ jobs:
           npm ci
           npx playwright install
           npx playwright install-deps
+        env:
+          HUSKY: 0
 
       - name: Generate (Pre-)Release Draft
         if: ${{ steps.prep.outputs.tag_name == '' }}
@@ -365,6 +367,7 @@ jobs:
         working-directory: ./tests/fixtures/post-release/cucumber
         env:
           BUILD_ID: Github RUN ID ${{ env.GITHUB_RUN_ID }}
+          HUSKY: 0
         run: |
           npm ci --production
           saucectl run --runner-version "url: https://github.com/saucelabs/sauce-playwright-runner/releases/download/${{ steps.parse_version.outputs.version }}/playwright-windows-amd64.zip" --config ./.sauce/config_win.yml
@@ -399,6 +402,7 @@ jobs:
         working-directory: ./tests/fixtures/post-release/cucumber
         env:
           BUILD_ID: Github RUN ID ${{ env.GITHUB_RUN_ID }}
+          HUSKY: 0
         run: |
           npm ci --production
           saucectl run --runner-version "url: https://github.com/saucelabs/sauce-playwright-runner/releases/download/${{ steps.parse_version.outputs.version }}/playwright-macos-amd64.zip" --config ./.sauce/config_mac.yml

.github/workflows/test.yml

@@ -29,6 +29,8 @@ jobs:
 
       - name: Install Dependencies
         run: npm ci
+        env:
+          HUSKY: 0
 
       - name: Lint
         run: npm run lint
@@ -53,6 +55,8 @@ jobs:
           npm ci
           npx playwright install
           npx playwright install-deps
+        env:
+          HUSKY: 0
 
       - name: Build
         run: npm run build
@@ -77,6 +81,8 @@ jobs:
           npm ci
           npx playwright install
           npx playwright install-deps
+        env:
+          HUSKY: 0
 
       - name: Build
         run: npm run build
@@ -104,7 +110,7 @@ jobs:
       - name: Setup Python
         uses: actions/setup-python@v5
         with:
-          python-version: '3.12'
+          python-version: "3.11"
 
       - name: Google Cloud Login
         uses: 'google-github-actions/auth@v2'
@@ -152,7 +158,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
-          python-version: "3.12"
+          python-version: "3.11"
 
       - name: Google Cloud Login
         id: "auth"
@@ -241,7 +247,7 @@ jobs:
       - name: Setup Python
         uses: actions/setup-python@v5
         with:
-          python-version: "3.12"
+          python-version: "3.11"
 
       - name: Setup saucectl
         uses: saucelabs/saucectl-run-action@v4
@@ -314,3 +320,5 @@ jobs:
           saucectl run \
             --runner-version "url: ${BUNDLE_URL}" \
             --config .sauce/config_${{ matrix.os }}.yml
+        env:
+          HUSKY: 0

.husky/pre-commit

@@ -1,4 +1,2 @@
-#!/usr/bin/env sh
-. "$(dirname -- "$0")/_/husky.sh"
-
+npx pretty-quick --staged --pattern "**/*.{js,ts,mjs,cjs}"
 npm run lint

eslint.config.js → eslint.config.mjs

@@ -1,9 +1,10 @@
-const ts = require('typescript-eslint');
-const js = require('@eslint/js');
-const prettier = require('eslint-config-prettier');
-const jest = require('eslint-plugin-jest');
+// @ts-check
+import ts from 'typescript-eslint';
+import js from '@eslint/js';
+import prettier from 'eslint-config-prettier';
+import jest from 'eslint-plugin-jest';
 
-module.exports = ts.config(
+export default ts.config(
   js.configs.recommended,
   ...ts.configs.recommended,
   prettier,
@@ -13,7 +14,7 @@ module.exports = ts.config(
   {
     files: ['**/*.*js', '**/*.*ts'],
     rules: {
-      '@typescript-eslint/no-var-requires': 'off',
+      '@typescript-eslint/no-require-imports': 'off',
       '@typescript-eslint/no-explicit-any': 'warn',
       'no-control-regex': 'off',
       'no-undef': 'warn',

jest.config.js

@@ -1,11 +1,11 @@
 /** @type {import('jest').Config} */
 const config = {
   testMatch: ['**/tests/unit/**/*.[jt]s?(x)'],
-  collectCoverageFrom: ['src/**/*.js'],
+  collectCoverageFrom: ['src/**/*.ts'],
   collectCoverage: true,
-  transformIgnorePatterns: [
-    '/node_modules/(?!(axios)/)', // Uses module import statements, which aren't supported by jest, so it has to be transformed by babel.
-  ],
+  clearMocks: true,
+  coverageProvider: 'v8',
+  transform: { '^.+\\.ts?$': 'ts-jest' },
 };
 
 module.exports = config;