fix: Set global timeout conditionally (#229)

saucelabs · Aug 31, 2023 · 62ed9ca · 62ed9ca
1 parent e453510
commit 62ed9ca
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/src/playwright-runner.ts b/src/playwright-runner.ts
@@ -227,10 +227,6 @@ async function runPlaywright(nodeBin: string, runCfg: RunnerConfig): Promise<Run
     playwrightBin, 'test'
   ];
 
-  // Default value for timeout (30min)
-  if (!suite.param.globalTimeout) {
-    suite.param.timeout = 1800000;
-  }
   let args: Record<string, unknown> = _.defaultsDeep(defaultArgs, utils.replaceLegacyKeys(suite.param));
 
   // There is a conflict if the playwright project has a `browser` defined,

diff --git a/src/sauce.config.cjs b/src/sauce.config.cjs
@@ -26,6 +26,12 @@ for (const file of configFiles) {
   }
 }
 
+// Set a default timeout of 30 minutes if one is not provided. This protects
+// against tests that hang and never finish.
+if (!userConfig.globalTimeout) {
+  userConfig.globalTimeout = 1000 * 60 * 30; // 30 minutes
+}
+
 const overrides = {
   use: {
     headless: process.env.HEADLESS === 'true',

diff --git a/src/sauce.config.mjs b/src/sauce.config.mjs
@@ -27,6 +27,12 @@ for (const file of configFiles) {
   }
 }
 
+// Set a default timeout of 30 minutes if one is not provided. This protects
+// against tests that hang and never finish.
+if (!userConfig.globalTimeout) {
+  userConfig.globalTimeout = 1000 * 60 * 30; // 30 minutes
+}
+
 const overrides = {
   use: {
     headless: process.env.HEADLESS === 'true',