fix: nil pointer in saucectl configure command (#987)

* fix: nil pointer in saucectl configure command * ci: test saucectl configure e2e
saucelabs · Dec 4, 2024 · 3637d90 · 3637d90
1 parent 7f0aae3
commit 3637d90
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 2 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -106,6 +106,25 @@ jobs:
             saucectl
             saucectl.exe
 
+  test-configure:
+    needs: build
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v4
+
+      - name: Download saucectl Binary
+        uses: actions/download-artifact@v4
+        with:
+          name: saucectlbin
+
+      - name: Set Permissions
+        run: chmod +x ./saucectl
+
+      - name: Saucectl Configure
+        run: ./saucectl configure -u $SAUCE_USERNAME -a $SAUCE_ACCESS_KEY
+
   puppeteer-replay:
     needs: build
     runs-on: ubuntu-latest

diff --git a/internal/cmd/configure/cmd.go b/internal/cmd/configure/cmd.go
@@ -41,7 +41,6 @@ func Command() *cobra.Command {
 			go func() {
 				tracker.Collect(
 					cmds.FullName(cmd),
-					nil,
 				)
 				_ = tracker.Close()
 			}()

diff --git a/internal/usage/client.go b/internal/usage/client.go
@@ -73,7 +73,9 @@ func (c *Client) Collect(subject string, opts ...Option) {
 		Set("ci", ci.GetProvider().Name)
 
 	for _, opt := range opts {
-		opt(p)
+		if opt != nil {
+			opt(p)
+		}
 	}
 
 	userID := credentials.Get().Username