refactor: no err on worker pool creation (#968)

saucelabs · Nov 5, 2024 · f512bf3 · f512bf3
1 parent 070943a
commit f512bf3
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 30 deletions.
diff --git a/internal/saucecloud/cloud.go b/internal/saucecloud/cloud.go
@@ -90,7 +90,7 @@ type result struct {
 // ConsoleLogAsset represents job asset log file name.
 const ConsoleLogAsset = "console.log"
 
-func (r *CloudRunner) createWorkerPool(ccy int, maxRetries int) (chan job.StartOptions, chan result, error) {
+func (r *CloudRunner) createWorkerPool(ccy int, maxRetries int) (chan job.StartOptions, chan result) {
 	jobOpts := make(chan job.StartOptions, maxRetries+1)
 	results := make(chan result, ccy)
 
@@ -99,7 +99,7 @@ func (r *CloudRunner) createWorkerPool(ccy int, maxRetries int) (chan job.StartO
 		go r.runJobs(jobOpts, results)
 	}
 
-	return jobOpts, results, nil
+	return jobOpts, results
 }
 
 func (r *CloudRunner) collectResults(results chan result, expected int) bool {

diff --git a/internal/saucecloud/cucumber.go b/internal/saucecloud/cucumber.go
@@ -137,10 +137,7 @@ func (r *CucumberRunner) runSuites(app string, otherApps []string) bool {
 	sigChan := r.registerSkipSuitesOnSignal()
 	defer unregisterSignalCapture(sigChan)
 
-	jobOpts, results, err := r.createWorkerPool(r.Project.Sauce.Concurrency, r.Project.Sauce.Retries)
-	if err != nil {
-		return false
-	}
+	jobOpts, results := r.createWorkerPool(r.Project.Sauce.Concurrency, r.Project.Sauce.Retries)
 	defer close(results)
 
 	suites := r.Project.Suites

diff --git a/internal/saucecloud/cypress.go b/internal/saucecloud/cypress.go
@@ -128,10 +128,7 @@ func (r *CypressRunner) validateFramework(m framework.Metadata) error {
 func (r *CypressRunner) runSuites(app string, otherApps []string) bool {
 	sigChan := r.registerSkipSuitesOnSignal()
 	defer unregisterSignalCapture(sigChan)
-	jobOpts, results, err := r.createWorkerPool(r.Project.GetSauceCfg().Concurrency, r.Project.GetSauceCfg().Retries)
-	if err != nil {
-		return false
-	}
+	jobOpts, results := r.createWorkerPool(r.Project.GetSauceCfg().Concurrency, r.Project.GetSauceCfg().Retries)
 	defer close(results)
 
 	suites := r.Project.GetSuites()

diff --git a/internal/saucecloud/espresso.go b/internal/saucecloud/espresso.go
@@ -87,12 +87,9 @@ func (r *EspressoRunner) runSuites() bool {
 	sigChan := r.registerSkipSuitesOnSignal()
 	defer unregisterSignalCapture(sigChan)
 
-	jobOpts, results, err := r.createWorkerPool(
+	jobOpts, results := r.createWorkerPool(
 		r.Project.Sauce.Concurrency, r.Project.Sauce.Retries,
 	)
-	if err != nil {
-		return false
-	}
 	defer close(results)
 
 	suites := r.Project.Suites

diff --git a/internal/saucecloud/playwright.go b/internal/saucecloud/playwright.go
@@ -142,10 +142,7 @@ func (r *PlaywrightRunner) runSuites(app string, otherApps []string) bool {
 	sigChan := r.registerSkipSuitesOnSignal()
 	defer unregisterSignalCapture(sigChan)
 
-	jobOpts, results, err := r.createWorkerPool(r.Project.Sauce.Concurrency, r.Project.Sauce.Retries)
-	if err != nil {
-		return false
-	}
+	jobOpts, results := r.createWorkerPool(r.Project.Sauce.Concurrency, r.Project.Sauce.Retries)
 	defer close(results)
 
 	suites := r.Project.Suites

diff --git a/internal/saucecloud/replay.go b/internal/saucecloud/replay.go
@@ -75,10 +75,7 @@ func (r *ReplayRunner) runSuites(fileURI string) bool {
 	sigChan := r.registerSkipSuitesOnSignal()
 	defer unregisterSignalCapture(sigChan)
 
-	jobOpts, results, err := r.createWorkerPool(r.Project.Sauce.Concurrency, r.Project.Sauce.Retries)
-	if err != nil {
-		return false
-	}
+	jobOpts, results := r.createWorkerPool(r.Project.Sauce.Concurrency, r.Project.Sauce.Retries)
 	defer close(results)
 
 	suites := r.Project.Suites

diff --git a/internal/saucecloud/testcafe.go b/internal/saucecloud/testcafe.go
@@ -137,10 +137,7 @@ func (r *TestcafeRunner) runSuites(app string, otherApps []string) bool {
 	sigChan := r.registerSkipSuitesOnSignal()
 	defer unregisterSignalCapture(sigChan)
 
-	jobOpts, results, err := r.createWorkerPool(r.Project.Sauce.Concurrency, r.Project.Sauce.Retries)
-	if err != nil {
-		return false
-	}
+	jobOpts, results := r.createWorkerPool(r.Project.Sauce.Concurrency, r.Project.Sauce.Retries)
 	defer close(results)
 
 	suites := r.Project.Suites

diff --git a/internal/saucecloud/xcuitest.go b/internal/saucecloud/xcuitest.go
@@ -164,10 +164,7 @@ func (r *XcuitestRunner) runSuites() bool {
 	sigChan := r.registerSkipSuitesOnSignal()
 	defer unregisterSignalCapture(sigChan)
 
-	jobOpts, results, err := r.createWorkerPool(r.Project.Sauce.Concurrency, r.Project.Sauce.Retries)
-	if err != nil {
-		return false
-	}
+	jobOpts, results := r.createWorkerPool(r.Project.Sauce.Concurrency, r.Project.Sauce.Retries)
 	defer close(results)
 
 	suites := r.Project.Suites