Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding imagerunner services #839

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Adding imagerunner services #839

merged 3 commits into from
Oct 4, 2023

Conversation

sebv
Copy link
Member

@sebv sebv commented Oct 1, 2023 •
edited
Loading

Proposed changes

Add imagerunner service container feature. This is similar to gitlab-ci service container, lets customers run side containers with their tests.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

This is for devx to take ownership, feel free to change the saucectl input.

@sebv sebv requested a review from a team as a code owner October 1, 2023 23:40
@sebv sebv force-pushed the sebv-imagerunner-services branch from 5d00267 to 7a7b2d7 Compare October 2, 2023 00:03
@alexplischke alexplischke marked this pull request as draft October 2, 2023 15:22
@sebv sebv marked this pull request as ready for review October 3, 2023 05:25
@alexplischke alexplischke added the enhancement New feature or request label Oct 3, 2023
@alexplischke
Copy link
Contributor

LGTM, though pipeline's not passing? (https://github.com/saucelabs/saucectl/actions/runs/6374664816/job/17299589872?pr=839) Is the backend not quite ready yet?

@sebv
Copy link
Member Author

sebv commented Oct 3, 2023

Looks like a bug in backend mounting files on service container, let me fix first.

@sebv
Copy link
Member Author

sebv commented Oct 4, 2023 •
edited
Loading

Backend bug is fixed.

@alexplischke alexplischke merged commit 5f17154 into main Oct 4, 2023
18 checks passed
@alexplischke alexplischke deleted the sebv-imagerunner-services branch October 4, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexplischke alexplischke alexplischke approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebv @alexplischke