Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve client instantiation #852

Merged
merged 11 commits into from
Nov 15, 2023
Merged

chore: Improve client instantiation #852

merged 11 commits into from
Nov 15, 2023

Conversation

mhan83
Copy link
Contributor

@mhan83 mhan83 commented Nov 14, 2023 •
edited
Loading

Proposed changes

Instead of partially instantiating all the service clients, fully instantiate them when they are needed.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have updated the json schema (if appropriate)

Further comments

@mhan83 mhan83 added the ignore-for-release Pull requests that aren't release relevant label Nov 14, 2023
@mhan83 mhan83 marked this pull request as ready for review November 14, 2023 18:44
@mhan83 mhan83 requested a review from a team as a code owner November 14, 2023 18:44
tianfeng92
tianfeng92 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@tianfeng92 tianfeng92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mhan83 mhan83 merged commit 08547fc into main Nov 15, 2023
19 checks passed
@mhan83 mhan83 deleted the devx-2640 branch November 15, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianfeng92 tianfeng92 tianfeng92 approved these changes

Assignees
No one assigned
Labels
ignore-for-release Pull requests that aren't release relevant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhan83 @tianfeng92