feat: Support takeScreenshot #11
Conversation
| ); | ||
| async takeScreenshot( | ||
| browserId: string, | ||
| screenshotPath: string, |
There was a problem hiding this comment.
The screenshotPath has already been converted to an absolute path and has the .png extension added by TestCafe. There's no need for further validation.
Additionally, it can create directories recursively, so we don't need to validate the directory's existence either.
| ) { | ||
| if (fullPage) { | ||
| console.warn( | ||
| 'Taking a full-page screenshot on the remote browser is not supported.', |
There was a problem hiding this comment.
No fullPage is mentioned in TestCafe plugin-host.js, but it can still be passed via t.takeScreenshot(path, fullPage). It is better to provide a warning message to indicate that full-page screenshots do not work for remote browsers.
Then extra crop would be applied after getting the screenshot. |
Description
It can support
.takeScreenshot()and.takeElementScreenshot()both.Note: The TestCafe Official provider also takes screenshots for BiDi browser types. I've checked our documentation, and we haven't enabled BiDi yet in this provider. Additionally, supporting BiDi features requires
[email protected]+, which is a pure ESM package, causing several issues for now.So, in this PR, I only added the functionality for taking screenshots for the W3C browser type.