Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[path-] fix undercounted progress for multibyte chars #2407

Closed
wants to merge 2 commits into from

Conversation

saulpw
Copy link
Owner

@saulpw saulpw commented May 16, 2024

I tried moving all the functionality from #2323 into a TextProgress class to keep it out of the path.py, and I simplified it some as I didn't want to join all the lines together. This probably regresses some performance issues that @midichef had already addressed; let's call out the perf cases we should test with. Ideally they could become part of a build load/save perf report.

@midichef
Copy link
Contributor

midichef commented Jun 6, 2024

Okay, I'll do some testing for loading speed.

Profiling has become easier now that #2369 has made replay behavior faster and more consistent. Before that, the loading time for a large file (using replay) varied quite a bit, with a standard deviation of 2-5% of the mean loading time. Testing a change used to require a few dozen runs to detect a few percentage points of improvement in loading time, which took about a half hour. After #2369, the standard deviation is 0.5-1%, and the individual runs are 30-80% faster on my system.

@midichef
Copy link
Contributor

Update, when I wrote:

the standard deviation [of the loading time for a large file has decreased, from 2-5% to]
0.5-1%, and the individual runs are 30-80% faster on my system.

I was wrong. I spoke after too little testing. The standard deviation is still in the range of a few percent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants