Skip to content

Fix: Normalize empty keyAlias to undefined before native bridge call #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbaiahmed1 merged 2 commits into from
Jul 5, 2026
Merged

Fix: Normalize empty keyAlias to undefined before native bridge call #92

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8057677
fix: normalize empty keyAlias to undefined before native bridge call
santisemhan Jun 10, 2026
ac43cb7
fix: coderabbitai suggestions
santisemhan Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,12 +269,13 @@ export function verifyKeySignature(
cancelButtonText?: string,
returnAuthType?: boolean
): Promise<SignatureResult> {
const resolvedKeyAlias = keyAlias || undefined;
logger.debug('Verifying key signature', 'verifyKeySignature', {
keyAlias,
dataLength: data.length,
});
return ReactNativeBiometrics.verifyKeySignature(
keyAlias,
resolvedKeyAlias,
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
data,
promptTitle,
promptSubtitle,
Expand Down Expand Up @@ -341,6 +342,8 @@ export function signWithOptions(
returnAuthType,
} = options;

const resolvedKeyAlias = keyAlias || undefined;

logger.debug('Signing with options', 'signWithOptions', {
keyAlias,
dataLength: data.length,
Expand All @@ -361,7 +364,7 @@ export function signWithOptions(
// On Android, use the new method with options
if (Platform.OS === 'android') {
return ReactNativeBiometrics.verifyKeySignatureWithOptions(
keyAlias,
resolvedKeyAlias,
data,
promptTitle,
promptSubtitle,
Expand All @@ -388,7 +391,7 @@ export function signWithOptions(

// On iOS, use the standard method with inputEncoding
return ReactNativeBiometrics.verifyKeySignatureWithEncoding(
keyAlias,
resolvedKeyAlias,
data,
promptTitle,
promptSubtitle,
Expand Down