Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(sbb-image): extract non-image-cdn related stuff #3200

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

refactor(sbb-image): extract non-image-cdn related stuff #3200

wants to merge 14 commits into from

Conversation

TomMenga
Copy link
Contributor

@TomMenga TomMenga commented Nov 6, 2024

This PR Closes #3090

TODOs

Create breaking changes message

sbb-image

  • Removed caption attribute
  • Removed copyright attribute
  • Removed copyrightHolder attribute
  • Removed borderRadius attribute
  • Removed aspectRatio attribute

Explain alternative to caption

sbb-teaser-hero

  • Removed image-src
  • Removed image-alt
  • Removed chip slot
  • New sbb-image slotting

sbb-teaser-product

  • New sbb-image slotting

sbb-teaser-product-static

  • New sbb-image slotting

sbb-teaser

  • New sbb-image slotting

@github-actions github-actions bot temporarily deployed to pr3200 November 7, 2024 09:58 Inactive
@github-actions github-actions bot temporarily deployed to pr3200-diff November 7, 2024 09:59 Inactive
@github-actions github-actions bot temporarily deployed to pr3200 November 11, 2024 09:00 Inactive
@github-actions github-actions bot temporarily deployed to pr3200-diff November 11, 2024 09:01 Inactive
@github-actions github-actions bot temporarily deployed to pr3200-diff November 11, 2024 11:50 Inactive
@github-actions github-actions bot requested a deployment to pr3200 November 13, 2024 13:44 In progress
@github-actions github-actions bot temporarily deployed to pr3200-diff November 13, 2024 13:44 Inactive
@github-actions github-actions bot requested a deployment to pr3200 November 13, 2024 15:05 In progress
@TomMenga TomMenga changed the title refactor(sbb-image): extract non-image-cdn related stuff [WIP] refactor(sbb-image): extract non-image-cdn related stuff Nov 13, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Nov 13, 2024
@TomMenga TomMenga added the pr: lead review required A lead review is required for this pull request label Nov 15, 2024
@TomMenga TomMenga self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@jeripeierSBB jeripeierSBB Awaiting requested review from jeripeierSBB jeripeierSBB is a code owner

@MarioCastigliano MarioCastigliano Awaiting requested review from MarioCastigliano

@dauriamarco dauriamarco Awaiting requested review from dauriamarco

@DavideMininni-Fincons DavideMininni-Fincons Awaiting requested review from DavideMininni-Fincons

At least 1 approving review is required to merge this pull request.

Assignees

@TomMenga TomMenga

Labels
diff-available pr: lead review required A lead review is required for this pull request pr: peer review required A peer review is required for this pull request pr: visual review required preview-available target: 1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

story: AI generated Chip
1 participant
@TomMenga