-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linting and testing errors #272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
`actions/setup-python@v4` supports reading the desired Python version from a `.python-version` file, so this way the two versions won't get out-of-sync. This is motived because Python 3.8.18 and 3.8.19 have different error messages for pyright tests being run, so the Python version should match exactly between the two.
This is the newest version of Python 3.8 available to the GitHub action: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
This reverts commit e6ccada. Now that the Python version is pinned to 3.8.18, these message changes are no longer necessary.
I've pushed some new commits that together fix the GitHub workflow failures by specifying an older version of Python 3.8 than before in See the commit messages for details. The version of Python this is based on should probably be updated to a newer version soon now that 3.8 is EOL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Not sure what went wrong with Kodiak here:
|
@sbdchd What should be done about these Kodiak errors? |
ah changing workflow files breaks the perms, I'll manually merge |
Thank you! |
django-stubs/db/transaction.pyi
.Fixes expected Pyright error messages inEdit: With Python pinned to 3.8.18, these message changes are no longer necessary.tests/pyright/test_arrays.py
andtests/pyright/test_fields.py
.These changes allow
./s/lint
to run successfully on my machine.