Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting and testing errors #272

Merged
merged 6 commits into from
Nov 23, 2024
Merged

Fix linting and testing errors #272

merged 6 commits into from
Nov 23, 2024

Conversation

noelleleigh
Copy link

@noelleleigh noelleleigh commented Oct 22, 2024

  • Fixes Black formatting and import order in django-stubs/db/transaction.pyi.
  • Fixes expected Pyright error messages in tests/pyright/test_arrays.py and tests/pyright/test_fields.py. Edit: With Python pinned to 3.8.18, these message changes are no longer necessary.

These changes allow ./s/lint to run successfully on my machine.

Copy link
Owner

@sbdchd sbdchd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

`actions/setup-python@v4` supports reading the desired Python version
from a `.python-version` file, so this way the two versions won't get
out-of-sync.

This is motived because Python 3.8.18 and 3.8.19 have different error
messages for pyright tests being run, so the Python version should match
exactly between the two.
This reverts commit e6ccada.

Now that the Python version is pinned to 3.8.18, these message changes
are no longer necessary.
@noelleleigh
Copy link
Author

I've pushed some new commits that together fix the GitHub workflow failures by specifying an older version of Python 3.8 than before in .python-version.

See the commit messages for details.

The version of Python this is based on should probably be updated to a newer version soon now that 3.8 is EOL.

Copy link
Owner

@sbdchd sbdchd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@noelleleigh
Copy link
Author

Not sure what went wrong with Kodiak here:

⚠️ problem contacting GitHub API with method 'kodiak/merged_blocked_unknown_reason'

Errors encountered when contacting GitHub API.

  • API call 'kodiak/merged_blocked_unknown_reason' failed with HTTP status '0' and response: "b''"
  • API call 'kodiak/merged_blocked_unknown_reason' failed with HTTP status '0' and response: "b''"
  • API call 'kodiak/merged_blocked_unknown_reason' failed with HTTP status '0' and response: "b''"
  • API call 'kodiak/merged_blocked_unknown_reason' failed with HTTP status '0' and response: "b''"
  • API call 'kodiak/merged_blocked_unknown_reason' failed with HTTP status '0' and response: "b''"

@noelleleigh
Copy link
Author

@sbdchd What should be done about these Kodiak errors?

@sbdchd
Copy link
Owner

sbdchd commented Nov 23, 2024

ah changing workflow files breaks the perms, I'll manually merge

@sbdchd sbdchd merged commit d7c95ba into sbdchd:main Nov 23, 2024
2 checks passed
@sbdchd
Copy link
Owner

sbdchd commented Nov 23, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants