Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simplify Parse trait by using Vec<u8> instead of AyncWriteExt #30

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

sbernauer
Copy link
Owner

@sbernauer sbernauer commented Jun 8, 2024

This should also improve performance for write only traffic (which is 99% of the traffic) as we can remove the overhead of async and error handling.

We (@fabi321, @bits0rcerer and @sbernauer) tested the performance during GPN22 and come to the following measurements:

Hardware before after
@sbernauer Laptop 16G 21G
@fabi321s Laptop 26G 28G
@bits0rcerer Laptop 78G 82G
80 core Ampere server (arm) 420G 407G

So to sum it up it's faster on all x86 machines, but somehow slower on the big arm server. I really don't know how removing async and error-handling make thing slower but I guess the x86 speedup is more important.

@sbernauer sbernauer changed the title refactor: Simply Parse trait by using Vec<u8> instead of AyncWriteExt refactor: Simplify Parse trait by using Vec<u8> instead of AyncWriteExt Jun 9, 2024
@sbernauer sbernauer merged commit f53ff62 into main Jun 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant