refactor: Simplify Parse trait by using Vec<u8> instead of AyncWriteExt #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also improve performance for write only traffic (which is 99% of the traffic) as we can remove the overhead of async and error handling.
We (@fabi321, @bits0rcerer and @sbernauer) tested the performance during GPN22 and come to the following measurements:
So to sum it up it's faster on all x86 machines, but somehow slower on the big arm server. I really don't know how removing async and error-handling make thing slower but I guess the x86 speedup is more important.