-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: protocol and refactor for custom potential #1409
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (29.63%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
===========================================
- Coverage 89.31% 29.63% -59.68%
===========================================
Files 119 119
Lines 8779 8914 +135
===========================================
- Hits 7841 2642 -5199
- Misses 938 6272 +5334
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for adding. Much cleaner then the old CallableWrapper.
Some minor docstring changes can be made, bot happy to merge it as is.
fixes #1223 by introducing a protocol for custom potentials. This will expose the arguments that we expect for the custom potential and eliminates the need to explicitly check for arguments.