Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce spurious renderBufferUnderrun events during playback transitions by tracking when a ring buffer / processing-graph format change is in progress and suppressing underrun reporting during that window.
Changes:
- Add a new internal
Flags::pendingFormatChangebit to track when a ring buffer format transition is pending. - Set/clear
pendingFormatChangeduring non-gapless join handling in the decoding thread. - Suppress
renderBufferUnderrunevent enqueuing when a short read occurs whilependingFormatChangeis set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Sources/CSFBAudioEngine/Player/AudioPlayer.mm | Sets/clears a new “pending format change” flag around reconfiguration and gates underrun event generation on it. |
| Sources/CSFBAudioEngine/Player/AudioPlayer.h | Introduces pendingFormatChange flag and shifts renderEventDropped to the next bit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.