Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures the audio processing graph remains unchanged and functional when reconfiguring for a new format fails due to ring buffer allocation failure, avoiding leaving AVAudioEngine stopped/disconnected on that error path.
Changes:
- Allocate a temporary
spsc::AudioRingBufferfor the new format before stopping the engine or disconnecting nodes, and return early on allocation failure. - Adopt the newly allocated ring buffer via move assignment only after the engine/graph reconfiguration begins.
- Simplify the reconfiguration restart failure path by removing the TODO and returning failure immediately when the engine can’t restart.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.