Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amazon-corretto base image (17, 11) #207

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kijuky
Copy link
Contributor

@kijuky kijuky commented Jul 31, 2022

  • copy eclipse-temurin dockerfile
  • change apt-get -> yum (for amazon linux)
    • The base image doesn't even have tar or gzip so I'm running that first.

@francisdb
Copy link
Collaborator

I wonder at what point github will tell us we have too many builds

Are you actively using jdk 8?
Maybe this belongs in a fork?

@kijuky
Copy link
Contributor Author

kijuky commented Aug 1, 2022

Are you actively using jdk 8?

surely.... 8 is erased.

@kijuky
Copy link
Contributor Author

kijuky commented Aug 1, 2022

I wonder at what point github will tell us we have too many builds

In many cases, having an LTS is enough. So just 11 and 17. If you ever need 18, make another pull request at that time.

@kijuky kijuky changed the title Add amazon-corretto base image (18, 17, 11, 8) Add amazon-corretto base image (17, 11) Aug 1, 2022
@francisdb
Copy link
Collaborator

francisdb commented Aug 1, 2022

Looks like the scala 3 docker build is failing on something related to tput in the scala startup script:

https://github.com/lampepfl/dotty/blob/1130c52a6476d473b41a598e23f0415e0f8d76dc/dist/bin/common#L31-L34

introduced in scala/scala3#10304

Also found this related thread
edeliver/edeliver#188 (comment)

Might be something to report on the dotty issue tracker

@francisdb
Copy link
Collaborator

see scala/scala3#15796

@francisdb
Copy link
Collaborator

you could try adding -pagewidth 80 to the scala test script run as a temp workaround

@kijuky
Copy link
Contributor Author

kijuky commented Aug 1, 2022

you could try adding -pagewidth 80 to the scala test script run as a temp workaround

I will try it!

@kijuky
Copy link
Contributor Author

kijuky commented Aug 6, 2022

you could try adding -pagewidth 80 to the scala test script run as a temp workaround

I tried adding this option, but it didn't help. Even if I change the settings or environment variables, tput will always be executed. As a last resort, I renamed tput only when running scala.

Doesn't seem like a very good way to do it, but I was out of ideas... 😢

@kijuky kijuky closed this Dec 3, 2022
@kijuky kijuky force-pushed the feature/add-amazon-corretto branch from 1c53138 to b75d204 Compare December 3, 2022 12:29
@kijuky kijuky reopened this Feb 12, 2023
@kijuky kijuky marked this pull request as draft February 12, 2023 02:28
@kijuky kijuky force-pushed the feature/add-amazon-corretto branch from c98e178 to 8c93d71 Compare March 7, 2023 23:34
@francisdb
Copy link
Collaborator

francisdb commented Jul 2, 2024

Updated to latest 21, 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants