Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sbtVersion tag #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kijuky
Copy link
Contributor

@kijuky kijuky commented Feb 12, 2023

solves #217.

policy

In #217:

I was thinking to have the latest sbt version committed and a tag created

I implemented it.

detail

  • add sbtVersion tag
    • remove fetch latest sbt version task
    • fix default sbt version in Dockerfile to 1.8.2
  • remove scheduled trigger

@kijuky kijuky marked this pull request as ready for review February 12, 2023 02:04
@kijuky kijuky force-pushed the feature/add-sbt-version-tag branch from 9a40755 to 5509e12 Compare March 7, 2023 23:34
@francisdb
Copy link
Collaborator

Thanks @kijuky this is a first step but we need to find a way to automate the update that version tag whenever there is a new sbt version. Could be some other action that polls every day, commits and triggers this action? Any ideas?

@kijuky
Copy link
Contributor Author

kijuky commented Mar 23, 2023

Could be some other action that polls every day, commits and triggers this action? Any ideas?

I don't have an implementation yet, but when I heard about it, it felt like "scala steward". The problem is that this repository is not an sbt project, so

  • make a fork of scala steward or
  • make this repository a sbt project and get scala steward noticed (sbt project doesn't necessarily have to be a scala project)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants