Combine repository override configuration with file existence#148
Merged
eed3si9n merged 1 commit intoJul 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step to solving sbt/sbt#9369. Second part of the fix is sbt/sbt#9452.
Prior work that changed the JVM flag processing semantics, thereby causing the issue: sbt/sbt#8761
The processing pipeline involved in the issue:
override-build-repos: JVM flagsbt.override.build.repos=truerepository-override: Filerepositories_forceisOverrideRepositoriesboolean flag based on the data supplied by (1) sbt-launcher.sbt.override.build.repos=trueThe fix is two-fold:
isOverrideRepositories = configuredOverrideRepos || repoConfigOverrideExists.override-build-reposthat was removed in https://github.com/sbt/sbt/pull/8761/changes#diff-f12f6468a3b483d79284e248213d4c1897f90ab80159db60343f9d907abf5188L28. This would propagate the JVM flag to the launcher to be used inisOverrideRepositoriescomputation.This PR is the implementation of the part 1 of the fix. Once launcher is released, we can bump the launcher version on sbt/sbt and implement step (2).