Skip to content

Include jars from fullClassPath if they aren't initially calculated#103

Draft
mdedetrich wants to merge 1 commit into
sbt:mainfrom
mdedetrich:include-jars-from-full-classpath-if-not-initially-existing
Draft

Include jars from fullClassPath if they aren't initially calculated#103
mdedetrich wants to merge 1 commit into
sbt:mainfrom
mdedetrich:include-jars-from-full-classpath-if-not-initially-existing

Conversation

@mdedetrich

@mdedetrich mdedetrich commented Jan 9, 2024

Copy link
Copy Markdown
Collaborator

Resolves: #102

Implements this solution

At least on a glance to me it seems like a quick way to fix this is to combine both (dependencyClasspathAsJars in Compile).value.map(.data) ++ (products in Compile).value and (fullClasspath in Compile) but use (dependencyClasspathAsJars in Compile).value.map(.data) ++ (products in Compile).value as a preference which should still solve the underlying problem described in #60 .

@mdedetrich mdedetrich marked this pull request as draft January 9, 2024 03:25
@mdedetrich mdedetrich force-pushed the include-jars-from-full-classpath-if-not-initially-existing branch from 0c79492 to 24f06bb Compare January 9, 2024 03:32
@mdedetrich

Copy link
Copy Markdown
Collaborator Author

So this PR is failing to pass because the scripted test test-05-exportJars is stalling. test-10-multi-project-dependsOn-includePackage-versions is passing since there aren't any extra jars in (fullClasspath in Compile) that isn't contained within (dependencyClasspathAsJars in Compile).value.map(.data) ++ (products in Compile).value

@mdedetrich

Copy link
Copy Markdown
Collaborator Author

Blocked by #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix regression when using Jar's to force proper manifest files

1 participant