Skip to content

Cross-build to sbt 2#218

Merged
mkurz merged 17 commits into
sbt:mainfrom
anatoliykmetyuk:sbt2-port
May 19, 2026
Merged

Cross-build to sbt 2#218
mkurz merged 17 commits into
sbt:mainfrom
anatoliykmetyuk:sbt2-port

Conversation

@anatoliykmetyuk

@anatoliykmetyuk anatoliykmetyuk commented Apr 9, 2026

Copy link
Copy Markdown
Member

No description provided.

xuwei-k
xuwei-k reviewed Apr 9, 2026
View reviewed changes
Comment thread src/test/scala/com/github/sbt/osgi/OsgiSpec.scala Outdated
xuwei-k
xuwei-k reviewed Apr 9, 2026
View reviewed changes
Comment thread src/test/scala/com/github/sbt/osgi/OsgiSpec.scala Outdated
@mkurz

mkurz commented Apr 9, 2026

Copy link
Copy Markdown
Member

😢

[error] /home/runner/work/sbt-osgi/sbt-osgi/src/test/scala/com/github/sbt/osgi/OsgiSpec.scala:44:18: not found: type URI
[error]         Some(new URI("http://example.example/").toURL),
[error]                  ^
[error] /home/runner/work/sbt-osgi/sbt-osgi/src/test/scala/com/github/sbt/osgi/OsgiSpec.scala:45:29: not found: type URI
[error]         Seq(("License", new URI("http://license.license/").toURL)),
[error]                             ^
[error] /home/runner/work/sbt-osgi/sbt-osgi/src/test/scala/com/github/sbt/osgi/OsgiSpec.scala:64:30: not found: type URI
[error]         BUNDLE_DOCURL -> new URI("http://example.example/").toURL.toString,
[error]                              ^

mkurz
mkurz reviewed Apr 9, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
mkurz
mkurz reviewed Apr 9, 2026
View reviewed changes
Comment thread build.sbt Outdated
@anatoliykmetyuk

anatoliykmetyuk commented Apr 9, 2026

Copy link
Copy Markdown
Member Author

😢

[error] /home/runner/work/sbt-osgi/sbt-osgi/src/test/scala/com/github/sbt/osgi/OsgiSpec.scala:44:18: not found: type URI
[error]         Some(new URI("http://example.example/").toURL),
[error]                  ^
[error] /home/runner/work/sbt-osgi/sbt-osgi/src/test/scala/com/github/sbt/osgi/OsgiSpec.scala:45:29: not found: type URI
[error]         Seq(("License", new URI("http://license.license/").toURL)),
[error]                             ^
[error] /home/runner/work/sbt-osgi/sbt-osgi/src/test/scala/com/github/sbt/osgi/OsgiSpec.scala:64:30: not found: type URI
[error]         BUNDLE_DOCURL -> new URI("http://example.example/").toURL.toString,
[error]                              ^

Fixed, green now ✅

@SethTisue

SethTisue commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

should we merge this and publish? I eyeballed it and it looks plausible, but I'm not knowledgeable about sbt 1/2 cross building

@SethTisue SethTisue mentioned this pull request May 13, 2026
Open
@anatoliykmetyuk

anatoliykmetyuk commented May 14, 2026

Copy link
Copy Markdown
Member Author

@mkurz is there anything else to do around this PR? Would be good to see it merged to unblock dependant plugins.

anatoliykmetyuk and others added 12 commits May 16, 2026 16:14
@anatoliykmetyuk @mkurz
Port sbt-osgi to sbt 2 cross-build
eb25d0a
@anatoliykmetyuk @mkurz
style: apply scalafmt
bcdf862
@anatoliykmetyuk @mkurz
ci: exclude JDK 8/11 for Scala 3.8.2; use JDK 17 for publish
812a1a0 
Scala 3.8+ requires JDK 17+ for the compiler bridge. Drop invalid
matrix pairs and put temurin@17 first so the publish job downloads
artifacts that the build job actually produces.
@mkurz @xuwei-k
URL to URI
ca82c6e 
Co-authored-by: kenji yoshida <6b656e6a69@gmail.com>
@mkurz @xuwei-k
URL to URI
69abb9f 
Co-authored-by: kenji yoshida <6b656e6a69@gmail.com>
@mkurz @xuwei-k
URL to URI
95fd2b3 
Co-authored-by: kenji yoshida <6b656e6a69@gmail.com>
@anatoliykmetyuk @mkurz
Update build.sbt
a2531c6 
Co-authored-by: Matthias Kurz <m.kurz@irregular.at>
@anatoliykmetyuk @mkurz
Update .github/workflows/ci.yml
20586b1 
Co-authored-by: Matthias Kurz <m.kurz@irregular.at>
@anatoliykmetyuk @mkurz
Fix test import
4855e57
@anatoliykmetyuk @mkurz
Regenerate ci.yml for Scala 3.8.3 (githubWorkflowGenerate)
3145f55
@anatoliykmetyuk @mkurz
Fix plugin compat
76fadab
@mkurz
Bump sbt versions
5172fa8
@mkurz

mkurz commented May 16, 2026

Copy link
Copy Markdown
Member

should be ready.

@anatoliykmetyuk

anatoliykmetyuk commented May 18, 2026

Copy link
Copy Markdown
Member Author

should be ready.

Great, thanks for polishing it! When can we expect it published to Maven for sbt 2?

@mkurz

mkurz commented May 19, 2026

Copy link
Copy Markdown
Member

then lets merge and push out a RC for testing

@mkurz mkurz merged commit 11039f5 into sbt:main May 19, 2026
26 of 49 checks passed
@anatoliykmetyuk anatoliykmetyuk deleted the sbt2-port branch May 19, 2026 07:08
@mkurz

mkurz commented May 19, 2026

Copy link
Copy Markdown
Member

Done

@xuwei-k xuwei-k mentioned this pull request Jun 24, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xuwei-k xuwei-k xuwei-k left review comments
@mkurz mkurz mkurz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anatoliykmetyuk @mkurz @SethTisue @xuwei-k