Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forking url for foundry #974

Draft
wants to merge 2 commits into
base: foundry
Choose a base branch
from

Conversation

moltam89
Copy link
Contributor

Hey guys,

This PR is the same as scaffold-eth#141.

Cheers,
Tamas

@technophile-04
Copy link
Collaborator

Thanks @moltam89 !! Umm thinking more on this, I think since now the our default Alchemy started working maybe we could use it as previously or even use public default rpc url and use alchemy in frontned.

The reason I say this because the devX is really bad, like after you run yarn fork it gives you this error:

Screenshot 2024-10-30 at 12 46 31 PM

People don't have any idea where they should put fork url. They need to need search for command how its used package.json => packages/foundry/package.json => makefile => fork

Gonna discuss this with SE-2 team! Keeping this on hold for now, but thanks for the PR!!

@technophile-04 technophile-04 marked this pull request as draft October 30, 2024 05:48
@moltam89
Copy link
Contributor Author

Thanks @technophile-04 !

Yeah, if we could run yarn fork out of the box, that would be the best!

Note:
Hardhat throws an ugly error message as well when we run yarn fork.
Screenshot 2024-10-30 at 08 13 28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants