WIP: Render text parts using refsDecls #71
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculation is done within the XSLT and within word_tokens; we may
be able to simplify this in the future.
This would also require the XSL stylesheet at the site level to be updated:
```
<xsl:template match="text()">
<xsl:variable name="node" select="." />
<xsl:for-each select="py:tokens(.)">
<xsl:choose>
<xsl:when test="py:token_type(.) = 'w'">
<xsl:element name="t">
...
<xsl:attribute name="passageIdx"><xsl:value-of select="py:token_passage_idx(.)" /></xsl:attribute>
...
```
Creates a lookup from word_tokens and allows the XLST
to map from passage token position to veRef
```
<xsl:template match="text()">
<xsl:variable name="node" select="." />
<xsl:for-each select="py:tokens(.)">
<xsl:choose>
<xsl:when test="py:token_type(.) = 'w'">
<xsl:element name="t">
...
<xsl:attribute name="veRef"><xsl:value-of select="py:token_ve_ref(.)" /></xsl:attribute>
...
```
Will allow us to pass sub references through to the front end while ignoring them for querying things internally
This commit introduces several XSLT functions that are used to resolve text parts. We pass the Citation (refsDecl) instances for a text to the renderer, and then use the xpaths from each citation to query the XML fragment for text parts. This improves upon earlier attempts by not relying on `div[type=textpart]` or on `l[@n]` for selectors. I made several processing passes to land on the current implementation; Timing notes: `/library/passage/urn:cts:latinLit:phi0893.phi001.perseus-lat2:1/json/` previous implementation: 0.299s new implementation: 0.680s (the new implementation has the new tokenization bits too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple
type="textpart"from refsDecl when rendering text parts / ribbon in SV 1