Announcing Scala.js 1.18.1. #649
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm0
requested changes
Jan 7, 2025
| if (i > 40) throw new IllegalArgumentException | ||
| } | ||
| class Child extends Parent({ | ||
| val p = try new Parent(42) catch { case _: IllegalArgumentException => break() } |
There was a problem hiding this comment.
IMO this is very confusing, because the Parent class is also used as a value. How about:
Suggested change
| val p = try new Parent(42) catch { case _: IllegalArgumentException => break() } | |
| val p = try Integer.parseInt("foo") catch { case _: NumberFormatException => break() } |
And remove the check in Parent?
| The changes you are most likely to hit are: | ||
|
|
||
| * We renamed `NoType` to `VoidType`, which represents the IR type `void`. | ||
| `void` is now generally handled more regularly, as any other type of the type system. |
There was a problem hiding this comment.
Suggested change
| `void` is now generally handled more regularly, as any other type of the type system. | |
| `void` is now generally handled more regularly. |
?
gzm0
approved these changes
Jan 7, 2025
|
I just opened an issue and its fix PR in the core repo. It actually seems pretty important. Maybe we should immediately release a 1.18.1 and skip 1.18.0. |
gzm0
approved these changes
Jan 8, 2025
adpi2
reviewed
Jan 8, 2025
| @@ -34,3 +34,4 @@ | |||
| - 1.13.0 | |||
| - 1.16.0 | |||
| - 1.17.0 | |||
| - 1.18.0 | |||
There was a problem hiding this comment.
No, this is the list of base versions for IR. They're all .0s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.