Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

Experiment to compile to 2.12 and cross to 2.11, drop 2.10. #451

Open
wants to merge 5 commits into
base: 0.11.x
Choose a base branch
from

Conversation

ekrich
Copy link

@ekrich ekrich commented Mar 24, 2017

  • removed all the straight deprecations
  • added access to sun.misc.Unsafe in Util - removed in 2.12
  • might be useful if anyone wants to update the library for 2.12
  • there are many other macro code deprecations that would take time to remove

Compiles except for benchmark and tests. If the build (project/Util.scala) is changed to 2.11.8 only, everything compiles and the tests run so clearly there are some differences when using 2.12.1 that don't work. I suspect that there is still a reference to scala.concurrent.util.Unsafe.instance. This would work in 2.11 but not 2.12.

Note: I used whitebox macros.

- removed all the straight deprecations
- added access to sun.misc.Unsafe in Util - removed in 2.12
- might be useful if anyone wants to resurrect the library
@ekrich
Copy link
Author

ekrich commented Mar 24, 2017

This is the sign of scala.concurrent.util

[info]     val pickle = data.pickle
[info]                       ^
[info] /Users/eric/workspace/pickling/benchmark/SparkLR.scala:32: genPickler is not a valid implicit value for scala.pickling.Pickler[spark.util.Vector] because:
[info] hasMatchingSymbol reported error: object util is not a member of package concurrent

@NirvanaNrv
Copy link

You have a typo with "picking" instead of "pickling" in the second commit. It compiles afterwards.

@ekrich
Copy link
Author

ekrich commented Apr 25, 2017

Thanks for the tip, compiles now with 3 test failures.

@ekrich
Copy link
Author

ekrich commented Apr 25, 2017

The following 3 tests fail probably due to 2.12 lambda encoding differences.

  • AnonfunBinaryTest
  • AnonfunJsonTest
  • Transient2SparkTest

CI worked for 2.11 (no test failures). CI does not support 2.12 compiling. Failed for 2.10 build (removed support from codebase)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants