chore: effectively use tasty-inspector in scaladoc#22803
Closed
hamzaremmal wants to merge 1 commit intoscala:mainfrom
Closed
chore: effectively use tasty-inspector in scaladoc#22803hamzaremmal wants to merge 1 commit intoscala:mainfrom
hamzaremmal wants to merge 1 commit intoscala:mainfrom
Conversation
This partially reverts scala#21929's fix but keeps the tests that were introduced
Contributor
|
I believe the underlying problem there was the fact that we didn't pass the settings from the scaladoc Context to the underlying tasty-inspector Context (and going back to just reusing the Context was a quick fix for that, since we wanted to fix the regressions). Also the test I ended adding is an sbt-scripted test, not the scaladoc test (so watch out for that) |
Contributor
|
@jchyb @hamzaremmal can we close this? At a glance, it feels like we no longer want to revert the fix? |
Gedochao
added
the
stat: stale PR
Contributor
|
Closing due to inactivity. |
Member
Author
Well, it was a dirty fix done there. The idea here is to get rid of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts #21929's fix but keeps the tests that were introduced