bugfix: Fix possible SuspendException thrown when using macros #24174
+22
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochala
reviewed
Oct 13, 2025
| val tpe = asDefLikeType(tree.typeOpt.dealias) | ||
| termRef.denot.asSingleDenotation.mapInfo(_ => tpe) | ||
| } | ||
| catch case NonFatal(_) => None |
There was a problem hiding this comment.
What is crashing here ? There is already try catch in tryApplyingExtensionMethod. I'd say we should not hide such errors, it will be impossible to know. The same goes for latter change.
I strongly believe we should never fallback to default values without logging.
There was a problem hiding this comment.
The stack trace is in scalameta/metals#7872
It's a bit beyond me to know how to even minimize it :/
There was a problem hiding this comment.
The try in tryApplyingExtensionMethod is not catching it, it's only catching UnhandledError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scalameta/metals#7872