Add time quota in checking global objects #24706
Open
+122
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
analysis-quota
branch
from
ccbd61b to
227ac2b
Compare
liufengyun
commented
Dec 16, 2025
| init(tpl, obj, classSym) | ||
| catch case _: OutOfQuotaException => | ||
| if !BestEffort then | ||
| report.warning("Giving up checking initializatino of " + classSym + " due to exhausted budget", classSym.sourcePos) |
Contributor
Author
There was a problem hiding this comment.
Should we turn on this warning for best-effort mode?
Contributor
Author
There was a problem hiding this comment.
Discussed this in meeting and it's agreed useful to display the warning in both modes: end users can learn from the warning that their initialization code is too complex.
Contributor
Author
|
It's interesting to see that the changes do not impact the test cases. With the assumption that most real-world cases are simple, we expect the changes to NOT impact most use cases, but only defend against edge cases. |
Co-authored-by: Ondřej Lhoták <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make global object checker default to best-effort mode
In both modes, there will be a worst-case performance guarantee based on a quota on the number of method calls in initializing a global object.