Add ctor proxies before exports #24884
Merged
+86
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
requested changes
Jan 16, 2026
|
|
||
| /** Does symbol `sym` need constructor proxies to be generated? */ | ||
| def needsConstructorProxies(sym: Symbol)(using Context): Boolean = | ||
| !sym.isTerm |
Contributor
There was a problem hiding this comment.
I don't think this optimization is needed. If it is a term, the previous logic would ask isClass and then isType and then return false. Both of these calls are extremely cheap. So, no need to complicate the logic in this case.
Contributor
Author
There was a problem hiding this comment.
| if hasExport(rest) then | ||
| hasExport(rest) && { | ||
| process(rest) | ||
| exported |
Contributor
There was a problem hiding this comment.
This construct is logically correct but mixes two concerns. I would suggest to something more along the lines of what we had:
if hasExport(rest) then
process(rest)
exported
Contributor
Author
There was a problem hiding this comment.
it would have made sense as hasExport(rest) && process(rest)
som-snytt
force-pushed
the
issue/15944-ctor-proxy-ext-export
branch
from
98c2ba1 to
0a80266
Compare
Contributor
Author
|
Took suggestions (which are discreetly squashed) and rebased. |
odersky
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15944
Fixes #24879
If exports added members, then check for more constructor proxies.
Follow up previous tweak for using constructor proxy of exported member, by preserving its prefix.
Although
needsConstructorProxiesis not expensive, it's also cheap to exclude terms first and save calls; there are many more term members than types.