Skip to content

Actually run tests in FromTastyTests? #24904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alexarchambault wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −9
Draft

Actually run tests in FromTastyTests? #24904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef4a508
Clean-up unused variable and inline one with constant value
alexarchambault Jan 5, 2026
52018a1
Actually run tests in FromTastyTests
alexarchambault Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/test/dotty/tools/dotc/FromTastyTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class FromTastyTests {
// > scalac -Ythrough-tasty -Ycheck:all <source>

implicit val testGroup: TestGroup = TestGroup("posTestFromTasty")
compileTastyInDir(s"tests${JFile.separator}pos", defaultOptions,
compileTastyInDir(s"tests${JFile.separator}pos", defaultOptions.and("-experimental"),
fromTastyFilter = FileFilter.exclude(TestSources.posFromTastyExcludelisted)
).checkCompile()
}
Expand All @@ -34,7 +34,7 @@ class FromTastyTests {
// > scala Test

implicit val testGroup: TestGroup = TestGroup("runTestFromTasty")
compileTastyInDir(s"tests${JFile.separator}run", defaultOptions,
compileTastyInDir(s"tests${JFile.separator}run", defaultOptions.and("-experimental"),
fromTastyFilter = FileFilter.exclude(TestSources.runFromTastyExcludelisted)
).checkRuns()
}
Expand Down
14 changes: 7 additions & 7 deletions compiler/test/dotty/tools/vulpix/ParallelTesting.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1570,30 +1570,30 @@ trait ParallelTesting extends RunnerOrchestration:
val sourceDir = new JFile(f)
checkRequirements(f, sourceDir, outDir)

val (dirs, files) = compilationTargets(sourceDir, fromTastyFilter)
val (_, files) = compilationTargets(sourceDir, fromTastyFilter)

val filteredFiles = testFilter match
case _ :: _ => files.filter(f => testFilter.exists(f.getPath.contains))
case _ => Nil
case _ => files

assert(filteredFiles.nonEmpty)

class JointCompilationSourceFromTasty(
name: String,
file: JFile,
flags: TestFlags,
outDir: JFile,
fromTasty: Boolean = false,
) extends JointCompilationSource(name, Array(file), flags, outDir, if (fromTasty) FromTasty else NotFromTasty) {
) extends JointCompilationSource(name, Array(file), flags, outDir, FromTasty) {

override def buildInstructions(errors: Int, warnings: Int): String = {
val runOrPos = if (file.getPath.startsWith(s"tests${JFile.separator}run${JFile.separator}")) "run" else "pos"
val listName = if (fromTasty) "from-tasty" else "decompilation"
s"""|
|Test '$title' compiled with $errors error(s) and $warnings warning(s),
|the test can be reproduced by running:
|
| sbt "testCompilation --from-tasty $file"
|
|This tests can be disabled by adding `${file.getName}` to `compiler${JFile.separator}test${JFile.separator}dotc${JFile.separator}$runOrPos-$listName.excludelist`
|This tests can be disabled by adding `${file.getName}` to `compiler${JFile.separator}test${JFile.separator}dotc${JFile.separator}$runOrPos-from-tasty.excludelist`
|
|""".stripMargin
}
Expand All @@ -1602,7 +1602,7 @@ trait ParallelTesting extends RunnerOrchestration:

val targets = filteredFiles.map { f =>
val classpath = createOutputDirsForFile(f, sourceDir, outDir)
new JointCompilationSourceFromTasty(testGroup.name, f, flags.withClasspath(classpath.getPath), classpath, fromTasty = true)
new JointCompilationSourceFromTasty(testGroup.name, f, flags.withClasspath(classpath.getPath), classpath)
}
// TODO add SeparateCompilationSource from tasty?

Expand Down
Loading