Also copy param annots at mixin #24916
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
review/22991-24892-mixin-param-annots
branch
from
1e530e2 to
daf27b4
Compare
ecrabor8
reviewed
Jan 8, 2026
ecrabor8
left a comment
ecrabor8
left a comment
There was a problem hiding this comment.
As far as I understand, this looks good and combines retaining method annotations and method parameter annotations in the mixin phase. If the test case passes go for it.
Co-authored-by: ecrabor8 <[email protected]>
som-snytt
force-pushed
the
review/22991-24892-mixin-param-annots
branch
from
daf27b4 to
6ac64bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22991
MixinOps#mkForwardSymalso copies annotations for forwarders, but not yet for parameters.New
paramssmust be reconstituted, and to these, annotations are copied from the member params "before transforms"; since that includes type params, those are filtered out.