Skip to content

Optimizer tests (disabled for now) #24948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SolalPirelli wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Optimizer tests (disabled for now) #24948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
dfa6041
Let IntelliJ delete an icon
SolalPirelli Jan 12, 2026
cfebb46
Minor cleanup, remove obsolete TODO
SolalPirelli Jan 12, 2026
b272191
Disable existing tests properly
SolalPirelli Jan 12, 2026
e5e95ac
Add new e2e tests, failing
SolalPirelli Jan 12, 2026
ae4bd8e
More
SolalPirelli Jan 12, 2026
47283a5
more
SolalPirelli Jan 13, 2026
a0b7efb
end?
SolalPirelli Jan 13, 2026
37a74f4
And the ignore
SolalPirelli Jan 13, 2026
560d9b1
Apply suggestion from @SolalPirelli
SolalPirelli Jan 13, 2026
3faffae
PR feedback
SolalPirelli Jan 13, 2026
417699f
Port more stuff
SolalPirelli Jan 13, 2026
1504859
Not needed
SolalPirelli Jan 13, 2026
f866bb3
More
SolalPirelli Jan 13, 2026
fa69811
Revert "Let IntelliJ delete an icon"
SolalPirelli Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions compiler/test/dotty/tools/backend/jvm/DottyBytecodeTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
package dotty.tools.backend.jvm
Copy link
Contributor Author

@SolalPirelli SolalPirelli Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: the icon.png deletion above, every time I open the project IntelliJ wants to do this, so...

Copy link
Contributor

@WojciechMazur WojciechMazur Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamzaremmal I don't really get why it was added in the first place in #21188 it's just for local users to make distinguishment of this repo easier, right ?

If the intelij suggests deletion then maybe we should check if that method is outdated or just add it to .gitignore (it's already commited so it's fine)

Copy link
Member

@hamzaremmal hamzaremmal Jan 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I use IntelliJ and it renders it in the projects list. scala 2 also has the same btw

Copy link
Contributor Author

@SolalPirelli SolalPirelli Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, in that case I'll revert this and figure out why that's happening on my machine later, thanks


import scala.language.unsafeNulls

import org.junit.Assert._
import org.junit.Assert.*
import org.junit.Test

import scala.tools.asm
import asm._
import asm.tree._

import asm.*
import asm.tree.*
import scala.tools.asm.Opcodes
import scala.jdk.CollectionConverters._
import Opcodes._
import scala.jdk.CollectionConverters.*
import Opcodes.*

class DottyBytecodeTests extends DottyBytecodeTest {
import ASMConverters._
Expand Down
48 changes: 6 additions & 42 deletions compiler/test/dotty/tools/backend/jvm/InlineBytecodeTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ package dotty.tools.backend.jvm

import scala.language.unsafeNulls

import org.junit.Assert._
import org.junit.Test
import org.junit.{Test, Ignore}

import scala.tools.asm.Opcodes._

Expand Down Expand Up @@ -75,46 +74,13 @@ class InlineBytecodeTests extends DottyBytecodeTest {
}
}

/** Disabled since locally comes from Predef now
@Test
def inlineLocally = {
val source =
"""
|class Foo {
| def meth1: Unit = locally {
| val a = 5
| a
| }
|
| def meth2: Unit = {
| val a = 5
| a
| }
|}
""".stripMargin

checkBCode(source) { dir =>
val clsIn = dir.lookupName("Foo.class", directory = false).input
val clsNode = loadClassNode(clsIn)
val meth1 = getMethod(clsNode, "meth1")
val meth2 = getMethod(clsNode, "meth2")

val instructions1 = instructionsFromMethod(meth1)
val instructions2 = instructionsFromMethod(meth2)

assert(instructions1 == instructions2,
"`locally` was not properly inlined in `meth1`\n" +
diffInstructions(instructions1, instructions2))
}
}
*/
/*
@Ignore("Intended to document how `.nn` is compiled, but out of date, and not useful until we have an optimizer that can eliminate dead code")
@Test def inlineNn = {
val source =
s"""
|class Foo {
| def meth1(x: Int | Null): Int = x.nn
| def meth2(x: Int | Null): Int = x.getClass; x
| def meth2(x: Int | Null): Int = { x.getClass; x.asInstanceOf[Int] }
|}
""".stripMargin

Expand All @@ -132,7 +98,7 @@ class InlineBytecodeTests extends DottyBytecodeTest {
diffInstructions(instructions1, instructions2))
}
}
*/

@Test def i4947 = {
val source = """class Foo {
| transparent inline def track[T](inline f: T): T = {
Expand Down Expand Up @@ -369,7 +335,7 @@ class InlineBytecodeTests extends DottyBytecodeTest {
}
}

// Testing that a is not boxed
// Testing that a is not boxed
@Test def i4522 = {
val source = """class Foo {
| def test: Int = {
Expand Down Expand Up @@ -478,7 +444,6 @@ class InlineBytecodeTests extends DottyBytecodeTest {
}
}


@Test def i9246 = {
val source = """class Foo:
| inline def check(v:Double): Unit = if(v==0) throw new Exception()
Expand Down Expand Up @@ -520,7 +485,6 @@ class InlineBytecodeTests extends DottyBytecodeTest {
}
}


@Test def i9466 = {
val source = """class Test:
| inline def i(inline f: Int => Boolean): String =
Expand Down Expand Up @@ -651,7 +615,7 @@ class InlineBytecodeTests extends DottyBytecodeTest {

val fun = getMethod(clsNode, "test")
val instructions = instructionsFromMethod(fun)
val expected = // TODO room for constant folding
Copy link
Contributor Author

@SolalPirelli SolalPirelli Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, this TODO was done (the code below was modified but this todo was kept)

val expected =
List(
IntOp(BIPUSH, 6),
Op(IRETURN),
Expand Down
Loading
Loading