Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mag setup in case of non public UPath. #1222

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Mag setup in case of non public UPath. #1222

wants to merge 4 commits into from
+8,128 −15,880

Conversation

valentin-pinkau
Copy link
Member

@valentin-pinkau valentin-pinkau commented Nov 28, 2024 •
edited
Loading

Description:

  • This PR fixes the setup of mags when their path is non public

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Added / Updated Tests

@markbader
Copy link
Contributor

LGTM 🙂

@markbader
Copy link
Contributor

markbader commented Nov 28, 2024 •
edited
Loading

Failing tests are probably due to changed requests that are not yet captured by vcr-py. You might try to run ./test.sh --refresh-snapshots in the webknossos directory. But as vcr-py has some problems recently, I am not sure if it will fix all tests.

@markbader
Copy link
Contributor

Please add a short note in the changelog file about the added auth token.

@valentin-pinkau
Copy link
Member Author

This is currently blocked by #1198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbader markbader markbader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentin-pinkau @markbader