Remove globalize floodfill job #7173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fm3 Could you remove the back-end code related to the globalize floodfill job? 😇 |
|
Done :) Should we write a migration removing these jobs from the db? Or is the front-end still able to list them in the table? |
|
Good point. I hadn't thought about it, but I just checked it: as long as the the front-end receives the job list as before (i.e., the backend can serialize these as JSON), it will show the floodfill jobs as before (because it handles the different job types quite generically). |
hotzenklotz
approved these changes
Jun 27, 2023
| @@ -463,7 +462,9 @@ export function* floodFill(): Saga<void> { | |||
| yield* put( | |||
| addUserBoundingBoxAction({ | |||
| boundingBox: coveredBoundingBox, | |||
| name: getBBoxNameForPartialFloodfill(oldSegmentIdAtSeed, activeCellId, seedPosition), | |||
| name: `Limits of flood-fill (source_id=${oldSegmentIdAtSeed}, target_id=${activeCellId}, seed=${seedPosition.join( | |||
There was a problem hiding this comment.
I am correctly assuming that this code is for the local, frontend only flood-fill operation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)