-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove globalize floodfill job #7173
Conversation
@fm3 Could you remove the back-end code related to the globalize floodfill job? 😇 |
Done :) Should we write a migration removing these jobs from the db? Or is the front-end still able to list them in the table? |
Good point. I hadn't thought about it, but I just checked it: as long as the the front-end receives the job list as before (i.e., the backend can serialize these as JSON), it will show the floodfill jobs as before (because it handles the different job types quite generically). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -463,7 +462,9 @@ export function* floodFill(): Saga<void> { | |||
yield* put( | |||
addUserBoundingBoxAction({ | |||
boundingBox: coveredBoundingBox, | |||
name: getBBoxNameForPartialFloodfill(oldSegmentIdAtSeed, activeCellId, seedPosition), | |||
name: `Limits of flood-fill (source_id=${oldSegmentIdAtSeed}, target_id=${activeCellId}, seed=${seedPosition.join( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am correctly assuming that this code is for the local, frontend only flood-fill operation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly 👍
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)