Add route to add segment index to existing volume annotations #7208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frcroth
reviewed
Jul 17, 2023
| annotation.downsample.volumeOnly=Downsampling is only possible for volume annotation layers. | ||
| annotation.addSegmentIndex.layerNotFound=Could not add segment index to volume annotation (annotation layer not found) | ||
| annotation.addSegmentIndex.explorationalsOnly=Could not add segment index to annotation because it is only allowed for explorational annotations. | ||
| annotation.addSegmentIndex.volumeOnly=Adding segment index is only possible for volume annotation layers. |
There was a problem hiding this comment.
annotation.addSegmentIndex.failed is used but does not occur here
| dataSet <- dataSetDAO.findOne(annotation._dataSet) ?~> "dataSet.notFoundForAnnotation" | ||
| _ <- bool2Fox(volumeAnnotationLayer.typ == AnnotationLayerType.Volume) ?~> "annotation.downsample.volumeOnly" | ||
| rpcClient <- tracingStoreService.clientFor(dataSet) | ||
| // duplicate in tracingstore will add segment index if possible |
There was a problem hiding this comment.
Can you point me to where that happens? Didn't immediately see it in VolumeTracingController.duplicate
There was a problem hiding this comment.
in combination with
Not sure how to make this more discoverable. Hence the comment here
There was a problem hiding this comment.
I guess line 361 in VolumeTracingService is the surprising one, so there could be a comment there "Adding segment index on duplication if the volume tracing allows it" or something like that.
frcroth
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds route to add a segment index to an existing volume annotaiton. Note that this is currently only available for volume annotaiton layer with no fallback segmentation.
Steps to test:
(I think no manual testing is required if the code looks good, as it is pretty hard to set up, and if we see this fail in production, not much harm is done and we can fix it then)
Issues: