-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add route to add segment index to existing volume annotations #7208
Conversation
annotation.downsample.volumeOnly=Downsampling is only possible for volume annotation layers. | ||
annotation.addSegmentIndex.layerNotFound=Could not add segment index to volume annotation (annotation layer not found) | ||
annotation.addSegmentIndex.explorationalsOnly=Could not add segment index to annotation because it is only allowed for explorational annotations. | ||
annotation.addSegmentIndex.volumeOnly=Adding segment index is only possible for volume annotation layers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
annotation.addSegmentIndex.failed
is used but does not occur here
dataSet <- dataSetDAO.findOne(annotation._dataSet) ?~> "dataSet.notFoundForAnnotation" | ||
_ <- bool2Fox(volumeAnnotationLayer.typ == AnnotationLayerType.Volume) ?~> "annotation.downsample.volumeOnly" | ||
rpcClient <- tracingStoreService.clientFor(dataSet) | ||
// duplicate in tracingstore will add segment index if possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you point me to where that happens? Didn't immediately see it in VolumeTracingController.duplicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 361 in 26baa68
hasSegmentIndex = VolumeSegmentIndexService.canHaveSegmentIndex(tracingWithResolutionRestrictions.fallbackLayer) |
in combination with
Line 403 in 26baa68
_ <- Fox.runIfOptionTrue(destinationTracing.hasSegmentIndex)( |
Not sure how to make this more discoverable. Hence the comment here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess line 361 in VolumeTracingService is the surprising one, so there could be a comment there "Adding segment index on duplication if the volume tracing allows it" or something like that.
Adds route to add a segment index to an existing volume annotaiton. Note that this is currently only available for volume annotaiton layer with no fallback segmentation.
Steps to test:
(I think no manual testing is required if the code looks good, as it is pretty hard to set up, and if we see this fail in production, not much harm is done and we can fix it then)
Issues: